-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material/chips): add (optional) edit icon to input chips #31041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deployed dev-app for fe5ea55 to: https://ng-dev-previews-comp--pr-angular-components-31041-dev-jgj91wpx.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
c0b7505
to
0dfcea0
Compare
4960510
to
809e1e8
Compare
b5951a7
to
3dbe36d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually I also realized that we should add a live example for the docs site. The examples live under components-examples
.
faec358
to
5c09c2b
Compare
Deployed docs-preview for fe5ea55 to: https://ng-dev-previews-comp--pr-angular-components-31041-docs-h4ff3yly.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
651cfd6
to
696752b
Compare
ea342eb
to
c779d8e
Compare
c8bbe6e
to
fe5ea55
Compare
Adds an optional edit icon to input chips to allow for better discoverability of editable chips over existing double-click and focus-enter to edit behavior.
The edit icon introduces concept of a leading action with an icon button similar to trailing action used for delete icon button. This can be combined with the existing avatar icon for a chip. The editable flag is preserved but is independent of the edit icon, allowing for both existing and new behavior or either one.
Updated chip demo to add option to show avatar and/or edit icon.